fix: co-int/str for CELs #5109

shahargl · 2025-06-28T15:09:21Z

vercel · 2025-06-28T15:09:25Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
keep	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2025 3:16pm

cursor

Bug: CEL Type Coercion Fails with `None` Values

The _coerce_eq_type_error method, intended for CEL type coercion, has multiple issues. Its get_nested helper function incorrectly attempts to access celpy activation objects as standard dictionaries, leading to None values and silent coercion failures. Additionally, the comparison logic is redundant: it always converts both values to strings for comparison, even after a specific check for mixed int/str types, rendering the initial check superfluous. Consequently, if get_nested returns None (e.g., for non-existent fields), str(None) is used in comparisons, potentially causing unintended matches with the literal string 'None'.

keep/rulesengine/rulesengine.py#L517-L549

keep/keep/rulesengine/rulesengine.py

Lines 517 to 549 in 655106f

    
               def get_nested(d, path): 
        
                   for part in path.split("."): 
        
                       if isinstance(d, dict): 
        
                           d = d.get(part) 
        
                       else: 
        
                           return None 
        
                   return d 
        
               left_val = get_nested(activation, left) 
        
               try: 
        
                   right_val = int(right) 
        
               except Exception: 
        
                   try: 
        
                       right_val = float(right) 
        
                   except Exception: 
        
                       right_val = right 
        
               # If one is str and the other is int/float, compare as str 
        
               if (isinstance(left_val, (int, float)) and isinstance(right_val, str)) or ( 
        
                   isinstance(left_val, str) and isinstance(right_val, (int, float)) 
        
               ): 
        
                   if op == "==": 
        
                       return str(left_val) == str(right_val) 
        
                   else: 
        
                       return str(left_val) != str(right_val) 
        
               # Also handle both as str for robustness 
        
               if op == "==": 
        
                   return str(left_val) == str(right_val) 
        
               else: 
        
                   return str(left_val) != str(right_val) 
        
           except Exception: 
        
               pass 
        
           return False

Fix in Cursor

Bug: Regex Greediness Causes Incorrect Parsing

The regex pattern r"([a-zA-Z0-9_\.]+)\s*([!=]=)\s*(.+)" used in the _coerce_eq_type_error function incorrectly parses complex CEL expressions. The greedy .+ capture group causes the right operand of a comparison (e.g., field == "value") to incorrectly include subsequent parts of the expression (e.g., "value" && other == 2). This leads to incorrect type coercion for == and != operators in such compound expressions.

keep/rulesengine/rulesengine.py#L505-L506

keep/keep/rulesengine/rulesengine.py

Lines 505 to 506 in 655106f


	m = re.match(r"([a-zA-Z0-9_\.]+)\s([!=]=)\s(.+)", cel)

Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

codecov · 2025-06-28T15:19:36Z

Codecov Report

Attention: Patch coverage is 2.04082% with 48 lines in your changes missing coverage. Please review.

Project coverage is 30.77%. Comparing base (0026346) to head (655106f).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
keep/rulesengine/rulesengine.py	2.04%	48 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5109       +/-   ##
===========================================
- Coverage   46.18%   30.77%   -15.41%     
===========================================
  Files         173      100       -73     
  Lines       17970    11454     -6516     
===========================================
- Hits         8299     3525     -4774     
+ Misses       9671     7929     -1742

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix: for #5107

2f2f20f

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Bug Something isn't working labels Jun 28, 2025

Merge branch 'main' into bugfix/5107

655106f

cursor bot reviewed Jun 28, 2025

View reviewed changes

vercel bot deployed to Preview June 28, 2025 15:16 View deployment

talboren approved these changes Jun 28, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 28, 2025

shahargl merged commit 4d07f64 into main Jun 28, 2025
18 of 20 checks passed

shahargl deleted the bugfix/5107 branch June 28, 2025 17:23

dosubot bot mentioned this pull request Jul 4, 2025

[🐛 Bug]: CEL filter in workflows when they are triggered, work differently comparing to alerts feed. #5148

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: co-int/str for CELs #5109

fix: co-int/str for CELs #5109

Uh oh!

shahargl commented Jun 28, 2025

Uh oh!

vercel bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

cursor bot left a comment

Uh oh!

codecov bot commented Jun 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


	def get_nested(d, path):
	for part in path.split("."):
	if isinstance(d, dict):
	d = d.get(part)
	else:
	return None
	return d

	left_val = get_nested(activation, left)
	try:
	right_val = int(right)
	except Exception:
	try:
	right_val = float(right)
	except Exception:
	right_val = right
	# If one is str and the other is int/float, compare as str
	if (isinstance(left_val, (int, float)) and isinstance(right_val, str)) or (
	isinstance(left_val, str) and isinstance(right_val, (int, float))
	):
	if op == "==":
	return str(left_val) == str(right_val)
	else:
	return str(left_val) != str(right_val)
	# Also handle both as str for robustness
	if op == "==":
	return str(left_val) == str(right_val)
	else:
	return str(left_val) != str(right_val)
	except Exception:
	pass
	return False

fix: co-int/str for CELs #5109

fix: co-int/str for CELs #5109

Uh oh!

Conversation

shahargl commented Jun 28, 2025

Uh oh!

vercel bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: CEL Type Coercion Fails with `None` Values

Bug: Regex Greediness Causes Incorrect Parsing

Uh oh!

codecov bot commented Jun 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jun 28, 2025 •

edited

Loading

codecov bot commented Jun 28, 2025 •

edited

Loading